-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-2170: Add validation to Torch numProcPerNode
field
#2409
base: master
Are you sure you want to change the base?
Conversation
70577cc
to
a74355d
Compare
a74355d
to
4b3c70d
Compare
4b3c70d
to
412f1f8
Compare
@@ -194,7 +195,7 @@ type Trainer struct { | |||
// Number of processes/workers/slots on every training node. | |||
// For the Torch runtime: `auto`, `cpu`, `gpu`, or int value can be set. | |||
// For the MPI runtime only int value can be set. | |||
NumProcPerNode *string `json:"numProcPerNode,omitempty"` | |||
NumProcPerNode *intstr.IntOrString `json:"numProcPerNode,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also thinking about changing numProcPerNode to IntOrString
. However, it is not a standard type in Python.
Thus, users should know what does this type mean: K8sIoApimachineryPkgUtilIntstrIntOrString
.
Or we need to make numProcPerNode: Union[int,str]
type.
Do we have any plans to expose numProcPerNode parameters to the Trainer object in SDK: https://github.com/kubeflow/trainer/blob/master/sdk/kubeflow/trainer/types/types.py#L73?
Or it will be always auto-populated based on num_nodes
and resources_per_node
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @kubeflow/wg-training-leads @Electronic-Waste
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I also think there should be a parameter exposed in the SDK. It is only loosely coupled with resources_per_node
.
The Kubernetes Python client declares IntOrString fields as object, but Union[int,str]
would be better.
Signed-off-by: Antonin Stefanutti <[email protected]>
412f1f8
to
905fbe7
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Change the TorchMLPolicy
numProcPerNode
type tointstr.IntOrString
and add CRD validation.Checklist: