Skip to content

Conversation

@mstruebing
Copy link
Member

@mstruebing mstruebing commented Dec 5, 2025

As discussed here: #2702
Updating the pre-check script to run on release branches.

Backports for current release branches (1.1 - 1.3):

Redacted output:

debian@box: /home/debian/projects/contrib/javascript git:(main)
➜   ./pre-check.sh
debian@box: /home/debian/projects/contrib/javascript git:(main)
➜   echo $?
0
debian@box: /home/debian/projects/contrib/javascript git:(main)
➜   git checkout release-1.1
Switched to branch 'release-1.1'
Your branch is up to date with 'origin/release-1.1'.
debian@box: /home/debian/projects/contrib/javascript git:(release-1.1)
➜   g cherry-pick 38b765883dd4ab0a9627fb6ee7288eabf7756cea
debian@box: /home/debian/projects/contrib/javascript git:(release-1.1)
➜   ./pre-check.sh
debian@box: /home/debian/projects/contrib/javascript git:(release-1.1)
➜   echo $?
0
debian@box: /home/debian/projects/contrib/javascript git:(release-1.1)
➜   g co main
Switched to branch 'main'
Your branch is ahead of 'origin/main' by 1 commit.
  (use "git push" to publish your local commits)
debian@box: /home/debian/projects/contrib/javascript git:(main)
➜   g co -b max/succeed-pre-check-on-release-branch
Switched to a new branch 'max/succeed-pre-check-on-release-branch'
debian@box: /home/debian/projects/contrib/javascript git:(max/succeed-pre-check-on-release-branch)
➜   ./pre-check.sh
This script can only be run on the main or release-* branches. Current branch is max/succeed-pre-check-on-release-branch

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2025
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjihrig, mstruebing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 67d6aa4 into main Dec 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants