Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to discuss how to handle the case when a PV is deleted while creating a VolumeGroupSnapshot #1183

Open
xing-yang opened this issue Nov 4, 2024 · 4 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@xing-yang
Copy link
Collaborator

What happened:
This was brought up during the code review: #1171 (comment). If a PV is deleted while creating a VolumeGroupSnapshot, should we bail out and fail the entire VolumeGroupSnapshot creation or should we continue and just leave the field for PV empty. If we do the later, that means we don't have a way to restore the PV that got deleted.

What you expected to happen:

How to reproduce it:

Anything else we need to know?:

Environment:

  • Driver version:
  • Kubernetes version (use kubectl version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@yati1998
Copy link
Contributor

yati1998 commented Nov 8, 2024

in my opinion it would be better to return error that pv has been deleted. Let me know how do you want it to work
cc @xing-yang
also please feel free to tag people who could answer it better and lets work on it.

@yati1998
Copy link
Contributor

@jsafrane any decision or suggestion on this?

@jsafrane
Copy link
Contributor

I think it's fair to create a VolumeSnapshotContent + VolumeSnapshot for such a snapshot, and not to refer to a PV / PVC in them. It's up to the user to figure out what data is on the snapshot.
I think the current implementation is written this way.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

5 participants