Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to sdk/resourcemanager/**/arm** from services/**/mgmt/** #2670

Closed
CecileRobertMichon opened this issue Sep 27, 2022 · 11 comments
Closed
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Comments

@CecileRobertMichon
Copy link
Contributor

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

Some of the azure-sdk-for-go packages used have been deprecated and replaced with newer versions of the libraries. Ref: https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/MIGRATION_GUIDE.md for migration.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • cluster-api-provider-azure version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 26, 2022
@CecileRobertMichon
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2023
@CecileRobertMichon
Copy link
Contributor Author

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 3, 2023
@CecileRobertMichon
Copy link
Contributor Author

/assign @mboersma @nojnhuh

@mboersma
Copy link
Contributor

/milestone v1.8

@k8s-ci-robot k8s-ci-robot modified the milestones: next, v1.8 Jan 12, 2023
@CecileRobertMichon
Copy link
Contributor Author

Summarizing status here:

We are currently exploring the route of leveraging Azure Service Operator for all Azure resources PUT/DELETEs. One advantage of this is that ASO is already using SDK v2. More on this at #3113.

@mboersma is working on a POC to migrate the async services to the SDK track 2 (this issue). @nojnhuh is working on a POC + proposal to explore introducing a dependency on ASO. The idea is to evaluate both alternatives (moving to ASO and migrating SDK track 2 with current SDK usage) as a path forward to accomplish the goal of no longer depending on SDK track 1.

The current plan is to migrate the services over one at a time (order TBD but prioritizing services where new features are blocked on this migration like managedclusters). We may also consider doing both simultaneously if we decide to go with migrating to ASO but switching over the SDK version requires less refactoring and can be done in parallel.

@jackfrancis jackfrancis modified the milestones: v1.8, next Mar 2, 2023
@mboersma mboersma modified the milestones: next, v1.9 Mar 9, 2023
@dtzar
Copy link
Contributor

dtzar commented Mar 20, 2023

As soon as we get more clarity on the ASO proposal, it would be good to convert this issue into more specific parts of the code where we DO need to migrate to SDK track 2.

@dtzar dtzar added priority/backlog Higher priority than priority/awaiting-more-evidence. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 5, 2023
@jackfrancis jackfrancis removed this from the v1.9 milestone Apr 6, 2023
@nojnhuh
Copy link
Contributor

nojnhuh commented Apr 6, 2023

This issue lists the current gaps: Azure/azure-service-operator#2237

@dtzar
Copy link
Contributor

dtzar commented Apr 17, 2023

Since Matt created #3409 which appears to supersede this, can we go ahead and close this issue?

@mboersma
Copy link
Contributor

/close

See #3409.

@k8s-ci-robot
Copy link
Contributor

@mboersma: Closing this issue.

In response to this:

/close

See #3409.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants