diff --git a/cloud/scope/machine_test.go b/cloud/scope/machine_test.go index 6059154e3..9ddf386ab 100644 --- a/cloud/scope/machine_test.go +++ b/cloud/scope/machine_test.go @@ -30,6 +30,7 @@ import ( metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/client-go/kubernetes/scheme" "k8s.io/klog/v2" + "k8s.io/utils/ptr" capiv1beta1 "sigs.k8s.io/cluster-api/api/v1beta1" "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/client/fake" @@ -133,7 +134,7 @@ func TestSetVPCProviderID(t *testing.T) { g := NewWithT(t) scope := setupMachineScope(clusterName, machineName, mock.NewMockVpc(gomock.NewController(t))) options.ProviderIDFormat = string("v1") - err := scope.SetProviderID(core.StringPtr(providerID)) + err := scope.SetProviderID(ptr.To(providerID)) g.Expect(err).ToNot(BeNil()) }) @@ -144,9 +145,20 @@ func TestSetVPCProviderID(t *testing.T) { utils.GetAccountIDFunc = func() (string, error) { return "dummy-account-id", nil // Return dummy value } - err := scope.SetProviderID(core.StringPtr(providerID)) + err := scope.SetProviderID(ptr.To(providerID)) g.Expect(err).To(BeNil()) }) + + t.Run("Set Provider ID returns error", func(t *testing.T) { + g := NewWithT(t) + scope := setupMachineScope(clusterName, machineName, mock.NewMockVpc(gomock.NewController(t))) + options.ProviderIDFormat = string("v2") + utils.GetAccountIDFunc = func() (string, error) { + return "", errors.New("error getting accountID") // Return dummy error + } + err := scope.SetProviderID(ptr.To(providerID)) + g.Expect(err).NotTo(BeNil()) + }) } func TestCreateMachine(t *testing.T) {