Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modification to Ports section for FixedIP addition #2393

Open
sachinphogat opened this issue Jan 24, 2025 · 3 comments
Open

Allow modification to Ports section for FixedIP addition #2393

sachinphogat opened this issue Jan 24, 2025 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sachinphogat
Copy link

sachinphogat commented Jan 24, 2025

/kind feature

Describe the solution you'd like
Allow addition of FixedIP post openstackmachine creation. This will help implement external IPAM solution. Post OpenstackMachine is created, I have developed external validating webhook to block OpenstackServer creation so that IPAM system will add FixedIP to openstack machine and validating webhook will let OpenstackServer to be created.

We need to allow modification to Ports spec for FixedIP addition post creation.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 24, 2025
@EmilienM
Copy link
Contributor

The OpenStackMachine is immutable, I don't think we can do that, right @mdbooth ?

@sachinphogat
Copy link
Author

Can we enhance by allowing this through validating webhook?

@mdbooth
Copy link
Contributor

mdbooth commented Jan 27, 2025

@sachinphogat As @EmilienM says machines are immutable, but this is more about 'we don't modify them after they've been created'. However, I think it could be valid, e.g. to use a lifecycle hook which prevents creation until external actors have had an opportunity to modify the object.

Can you do me a favour? Please can you start a conversation in #cluster-api slack about this and gather some ways others have achieved it and link that conversation here? I have a feeling it should involve lifecycle hooks rather than a mutating webhook, but I haven't done enough reading about how they are implemented to be sure.

I think this is a valid and interesting use case. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Inbox
Development

No branches or pull requests

4 participants