You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Specify buckets for "controller_runtime_reconcile_time_seconds" histogram metrics
Current metric uses Prometheus default bucket for reconcile time histogram. This bucket is
not sufficient to reason about percentile of requests which take less than x seconds when x falls outside
the bucket of 10 secs. It's also hard to infer when the reconcile loops are fairly fast, as mentioned in
this issue: #258.
This PR attempts to define explicit buckets for the metrics, values are chosen based on the apiserver
request latency defined here: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/metrics/metrics.go#L103.
The default Prometheus histogram buckets has also been added(wherever missing) to ensure backward compatibility.
0 commit comments