Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Infoblox provider 'registry_errors_total' metric #4705

Open
jdoylei opened this issue Aug 27, 2024 · 1 comment
Open

Improve Infoblox provider 'registry_errors_total' metric #4705

jdoylei opened this issue Aug 27, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jdoylei
Copy link

jdoylei commented Aug 27, 2024

What would you like to be added:

The Infoblox provider should increment external_dns_registry_errors_total when changes cannot be submitted due to WAPI request errors, e.g. :

CreateObject request error: 'WAPI request error: 404('404 Not Found')
Contents:
{ "Error": "AdmConDataNotFoundError: View  not found",
  "code": "Client.Ibap.Data.NotFound",
  "text": "View  not found"
}

Currently CreateObject errors do not get added to external_dns_registry_errors_total.

It looks like the counter relies on the error being propagated from the internal createRecords method to ApplyChanges here

Why is this needed:

Without this, the metric only catches a subset of issues and I have to supplement with log monitoring.

When we upgraded from 0.14.0 to 0.14.2, we had "View not found" errors relating to never having set the cmdline option "--infoblox-view=default". The errors only appear in container logs and not the metrics.

This is similar to enhancements made to error reporting in other providers, like Cloudflare in issue #4081.

@jdoylei jdoylei added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants
@jdoylei and others