-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEP-1291: Mesh
representation
#2565
GEP-1291: Mesh
representation
#2565
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: michaelbeaumont The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, thanks for the GEP. It looks good and seems like a reasonable path for this if we decide to go with it.
In my subjective opinion this doesn't help the project meaningfully. We are adding complexity that doesn't hold it's own weight in user benefit. FWIW I think the same about GatewayClass, though, so that may be an unpopular opinion :-)
Basically we are making a new resource (high cost!) with the idea that maybe we want to do things with it in the future (this is not convincing at all; we shouldnt weight hypotheticals highly) and to report some information.
This can, and imo should, simply be a page on a projects' documentation. This is orders of magnitude simpler while still providing as much (if not more!) value to users
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We appreciate your thoughts as always @howardjohn. These comments do seem to unfortunately provide slight ambiguity as to the prescription or specific actions to take on your behalf, however. The best read I can come up with of what action you may be prescribing is "don't proceed until we have stronger use cases / user stories". If that's the case I think asking for more and stronger emphasis on use cases and user stories seems legit, though I don't personally feel that it needs to hold us up from reaching a In any case it would seem prudent for many of us who focus on GAMMA to give this some deep through and review it: /cc @kflynn @keithmattix @mikemorris @whitneygriffith Please review and share your thoughts and ideas about the |
@shaneutt: GitHub didn't allow me to request PR reviews from the following users: whitneygriffith. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'll close this PR until we can discuss |
I like the idea here in the abstract (more than I like GatewayClass) and don't have any specific objections to the content of the GEP, but can agree we should hold off on introducing/requiring a |
What type of PR is this?
/kind gep
What this PR does / why we need it:
GAMMA implementations need a way to report conformance and CRD compatibility.
This GEP proposes a
Mesh
resource.Which issue(s) this PR fixes:
Fixes #1291
Does this PR introduce a user-facing change?: