Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing ListenerConditionType conformance test #1723

Open
nak3 opened this issue Feb 10, 2023 · 5 comments
Open

Add missing ListenerConditionType conformance test #1723

nak3 opened this issue Feb 10, 2023 · 5 comments
Assignees
@dprotaso
Labels
area/conformance kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@nak3
Copy link
Member

nak3 commented Feb 10, 2023 •
edited by shaneutt
Loading

ListenerConditionType changed recently: we need to do a review and determine if we have tests for every relevant permutation of conditions and reasons covered at least once in our conformance tests. Some of the tests may not be release blockers for v1.0.0 so it may be reasonable to spin up separate issues for those tracked separately.
@nak3 nak3 added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 10, 2023
@shaneutt shaneutt added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/conformance labels Feb 15, 2023
@shaneutt shaneutt added this to the v0.6.2 milestone Feb 15, 2023
@Xunzhuo
Copy link
Member

Xunzhuo commented Mar 8, 2023 •
edited
Loading

/assign

@shaneutt shaneutt moved this from Todo to In Progress in Gateway API: The Road to GA Mar 8, 2023
@shaneutt shaneutt modified the milestones: v0.6.2, v0.7.0 Mar 8, 2023
@robscott robscott modified the milestones: v0.7.0, v0.8.0 Mar 24, 2023
@shaneutt shaneutt modified the milestones: v0.8.0, v1.0.0 May 18, 2023
@shaneutt shaneutt moved this from In Progress to Next in Gateway API: The Road to GA May 18, 2023
@shaneutt shaneutt added release-blocker MUST be completed to complete the milestone help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 18, 2023
@shaneutt
Copy link
Member

We (the maintainers) were doing some review, and we decided this is something we can add after GA, though it is still something we'd like to look at.

/remove-label release-blocker
/remove-label help-wanted

However when we do get back around to it, it's not clear exactly how to move forward: we need someone to take the time to think through it and actually figure out the plan for how we're going to resolve this.

/priority important-longterm
/triage needs-information

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/needs-information Indicates an issue needs more information in order to work on it. labels Aug 22, 2023
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Aug 22, 2023
@shaneutt shaneutt removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-blocker MUST be completed to complete the milestone help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 22, 2023
@shaneutt shaneutt removed this from the v1.0.0 milestone Sep 27, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 28, 2024
@dprotaso
Copy link
Contributor

dprotaso commented Mar 8, 2024

/assign @dprotaso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dprotaso dprotaso

Labels
area/conformance kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@dprotaso @robscott @nak3 @shaneutt @k8s-ci-robot @Xunzhuo @k8s-triage-robot