-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI to Gateway API support #147
Comments
cc @youngnick @mikemorris @guicassolato |
Nice! Thanks @arkodg! Here are a few references of the Kuadrant feature I mentioned:
It's all from kuadrantctl. |
interesting. Was I in the loop as well? I cant remember. The suggestion is basically to add support very similar to what @guicassolato linked ? @arkodg this is different than the IR state you and I discussed right? |
Yeah the ask here is - OpenAPI in, GatewayAPI out, to improve config intent optimization
yeah .... this is an internal detail to improve code and internal schema reuse |
ack, thanks. |
/cc @robscott |
Hi @LiorLieberman. Absolutely! I'd be happy to. If I cannot send a PR in the next few days myself, I'll chase somebody in the Kuadrant team to do it. Please assign me to the issue. |
In time – this seems to be a feature that does not necessarily involve touching any Ingress resources. Are we sure we want it as part of ingress2gateway? Or perhaps you're thinking OpenAPI specs stored in Ingress annotations? If not, then what? A subcommand? Another option that comes to mind is |
@guicassolato imo its similar to the concept of provider which already exists today where provider specific resources are translated into gateway api, openapi/swagger can be treated as |
I was finally able to start working on this. I've spotted a few challenges that could lead to the following limitations:
Additionally, no support to any OpenAPI feature that would be obviously hard to translate to Gateway API resources, such as request bodies, examples, security schemes, callbacks, extensions, etc. I also have the following open questions:
@arkodg @mikemorris @LiorLieberman, I'd love to hear your thoughts. Footnotes |
With respect to "this doesn't take Ingress config", I think that we've talked before about how, although this tool is called I'm also excited for this to give some direction for folks on the right way to break up objects into HTTPRoutes. For @guicassolato's questions:
|
thanks for working on this one @guicassolato ! hoping we can convert the shortcomings into GH issues and add support for it in the upstream Gateway API reg 3. |
Thanks @guicassolato! Apologies for the late response, was out for a bit. |
Late following up on this, but documenting for posterity and potential future improvements
|
What would you like to be added:
Add the ability to convert OpenAPI (v2 and v3) input config into Gateway API config
e.g. https://petstore3.swagger.io
Why this is needed:
A lot of users seem to be hitting limits on the existing number of
rules
( max 8)kubernetes-sigs/gateway-api#1485
Creating a translation by the gateway api community should provide the recommended way to convert user API intent into Gateway API config, reducing the friction users are feeling today due to the limit
The text was updated successfully, but these errors were encountered: