return IP address using kubeconfig --internal #1583
Conversation
Before 0.8.0 kind get kubeconfig --internal returned the container IP address of the node with the API server. Since we added docker custom bridges, the behavior changed returning the hostname. We recover the previous behavior returning an IP address, however, it will return always an IPv4 address.
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aojea The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
|
/assign @BenTheElder I'm not super happy but I couldn't find a "clean" way of getting the cluster IP family without adding a new method to the provider or a new variable indicating it. Totally open to suggestions |
|
@aojea: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I don't think most internal clients should use IP still.
…On Wed, May 13, 2020, 04:15 Kubernetes Prow Robot ***@***.***> wrote:
Assigned #1583 <#1583> to
@BenTheElder <https://github.com/BenTheElder>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#1583 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHADKZGP5IDRBCMYZCBVCLRRJ6MBANCNFSM4M7U4B6A>
.
|
IIRC that the original purpose of the flag was for obtaining the docker IP, it may be used for other containers that do not belong to the cluster. |
|
adding a new parameter is too gross? |
no, the purpose of the flag is to obtain a kubeconfig for use inside the cluster network as opposed to the one we export for the host. wanting it to be an IP instead of whatever the internal default management is is ... different. |
BenTheElder
added
the
do-not-merge/hold
|
@aojea: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-rebase
|
btw when I tag an issue |
|
heh my fault, honestly, didn't see the tags and make my mind around it thinking that they only wanted the IPs, let's close and discuss then |
|
@aojea: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Before 0.8.0 kind get kubeconfig --internal returned the container
IP address of the node with the API server.
Since we added docker custom bridges, the behavior changed
returning the hostname.
We recover the previous behavior returning an IP address, however,
it will return always an IPv4 address.
Fixes: #1558