avoid tempfiles cleanup collision #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
BenTheElder
commented
Nov 6, 2019
| && mkdir -p /etc/kubernetes/manifests | ||
| && mkdir -p /etc/kubernetes/manifests \ | ||
| && echo "Adjusting systemd-tmpfiles timer" \ | ||
| && sed -i /usr/lib/systemd/system/systemd-tmpfiles-clean.timer -e 's#OnBootSec=.*#OnBootSec=1min#' |
There was a problem hiding this comment.
the default is 15m after boot and then every 24 hours.
for now just moving it to 1m after boot which imo makes more sense for kind nodes which generally live on a compressed times cale, and leaving the 24 hours alone.
the real fix is hopefully in the /var/tmp change 🙃
BenTheElder
commented
Nov 6, 2019
| @@ -43,7 +43,7 @@ import ( | |||
| const DefaultImage = "kindest/node:latest" | |||
|
|
|||
| // DefaultBaseImage is the default base image used | |||
| const DefaultBaseImage = "kindest/base:v20191030-ae10d883@sha256:bccb2ad3686a11ea920b5eaf701b252166affa3c3362e38c549374f1e467ae80" | |||
| const DefaultBaseImage = "kindest/base:v20191105-ee880e9b@sha256:f4c7c8ac0d387a18ba0bd2756b17551102b7322497796e3ad3f366c3e67c01d2" | |||
There was a problem hiding this comment.
built with the base image dockerfile tweak above
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... with exporting logs 🙃
fixes #999