trap INT and TERM in CI

[BenTheElder]

EXIT is not handled consistently across shells

this will be obviated by #986 but the need to debug some timeouts is a bit more pressing and this change is tiny ...

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[BenTheElder]

this one should already be doing this because it's bash, but the other script may be ash/dash (it's using sh)

[aojea]

this comment is confusing me regarding trapping EXIT
https://unix.stackexchange.com/a/149093

[BenTheElder]

There's also what @Shawn said: Ash and Dash don't trap signals with EXIT.

that's the only relevant part really.

POSIX has requirements about what it looks like when EXIT is called, but when it is called is under specified. we explicitly want these

[aojea]

/lgtm
it seems worth to try

[aojea]

/hold

we were lucky to hit a timeout https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kind/1627/pull-kind-e2e-kubernetes/1265745915679870979

and is not working :/

[aojea]

2 jobs timed out without logs :/
#1627 (comment)

[BenTheElder]

/hold cancel
there's other reasons we may not work during timeouts, this change is still correct

[aojea]

/retest
then 😄

[BenTheElder]

notably I'm concerned about how podutils / our config is handling these, I think we need a longer grace period.

May 27 21:06:34.545: INFO: Running AfterSuite actions on all nodes

{"component":"entrypoint","file":"prow/entrypoint/run.go:164","func":"k8s.io/test-infra/prow/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 40m0s timeout","time":"2020-05-27T21:29:25Z"}
{"component":"entrypoint","file":"prow/entrypoint/run.go:245","func":"k8s.io/test-infra/prow/entrypoint.gracefullyTerminate","level":"error","msg":"Process did not exit before 15s grace period","time":"2020-05-27T21:29:40Z"}

note those times, 15s is not even enough time for the ginkgo after-suite to finish.
the GCE jobs are on bootstrap.py

[BenTheElder]

/test all

[BenTheElder]

/test all

[aojea]

/test all

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[BenTheElder]

/test all
seems to be working as intended so far, though we haven't seen the timeout behavior

[aojea]

/test all
seems to be working as intended so far, though we haven't seen the timeout behavior

Jordan merged a PR related to the test with timeouts, I don't think it will show up again, if I read it correctly the test should timeout now, not the job

[BenTheElder]

timeouts are happening on other branches too.
/test all

[k8s-ci-robot]

@BenTheElder: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kind-e2e-kubernetes-1-18	a66e2bd	link	/test pull-kind-e2e-kubernetes-1-18
pull-kind-e2e-kubernetes	a66e2bd	link	/test pull-kind-e2e-kubernetes

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[BenTheElder]

At the very least this doesn't misbehave so far, merging so we can maybe start collecting logs elsewhere