add public API to detect node providers #2069
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
BenTheElder
force-pushed
the
provider-detect
branch
from
90c007c to
ef889b6
Compare
|
Not having people re-implement this to fail out early when there doesn't seem to be a provider available will be more important in the future when we have detection for some provider that is not a mere "$cli_binary is in path", which we'll likely want to do at some point. |
| } | ||
| return p | ||
| } | ||
|
|
||
| // NoNodeProviderDetectedError indicates that we could not autolocate an available | ||
| // NodeProvider backend on the host | ||
| var NoNodeProviderDetectedError = errors.NewWithoutStack("failed to detect any supported node provider") |
There was a problem hiding this comment.
we haven't actually had much in the way of client-handle-able errors yet (usually stuff like "cluster bringup failed in some unexpected way"), so I had to update the error utilities to handle this appropriately.
| // NewWithoutStack is like new but does NOT wrap with a stack | ||
| // This is useful for exported errors | ||
| func NewWithoutStack(message string) error { | ||
| return stderrors.New(message) |
There was a problem hiding this comment.
since this will necessarily be for making errors at the bottom of the stack that should not themselves contain a stack, this should be appropriate (a plain error with the message and nothing else).
|
installing podman is failing in the CI pipeline :| |
k8s-ci-robot
added
the
lgtm
|
hmm it seems to get github actions to run with the latest config you must manually rebase the PR. |
BenTheElder
force-pushed
the
provider-detect
branch
from
ef889b6 to
f960e32
Compare
k8s-ci-robot
removed
the
lgtm
|
/retest
I´m sufferin gthis every day 🙃 |
k8s-ci-robot
added
the
lgtm
see: #2067