Local registry: only attach network if missing #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
neolit123
reviewed
Jan 24, 2022
stmcginnis
force-pushed
the
network-connect-registry
branch
from
0134680 to
cc84ee8
Compare
|
thanks |
k8s-ci-robot
added
the
lgtm
BenTheElder
reviewed
Jan 24, 2022
The example script for creating a kind cluster with a local registry will connect the container to the "kind" network. The first time the local registry is created, this is fine and is what is needed. On subsequent runs to create new clusters, if the local registry container has already been set up, the command to attach to the "kind" network will emit an error message to the create output that can be confusing. This updates the example script to do a basic check of the registry containers network configuration. If the kind network appears to be already connected, then the script will not attempt to connect it again. Signed-off-by: Sean McGinnis <[email protected]>
stmcginnis
force-pushed
the
network-connect-registry
branch
from
cc84ee8 to
90eef3a
Compare
k8s-ci-robot
removed
the
lgtm
|
https://deploy-preview-2601--k8s-kind.netlify.app/docs/user/local-registry/ looks like it was about the scrollbox, but we can follow-up, this is a good change to land. thank you! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, stmcginnis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example script for creating a kind cluster with a local registry
will connect the container to the "kind" network. The first time the
local registry is created, this is fine and is what is needed. On
subsequent runs to create new clusters, if the local registry container
has already been set up, the command to attach to the "kind" network
will emit an error message to the create output that can be confusing.
This updates the example script to do a basic check of the registry
containers network configuration. If the kind network appears to be
already connected, then the script will not attempt to connect it again.
Fixed: #2600