-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local registry example uses port 5001 to be more mac friendly #2621
Conversation
Welcome @chaodaiG! |
Hi @chaodaiG. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this was tested in prow integration test and it worked kubernetes/test-infra#25134 |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, chaodaiG The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Vagrant flakes. |
Is this documentation up-to-date? https://kind.sigs.k8s.io/docs/user/local-registry/ I had to push the image to |
@Dentrax the docs cover the updated setup, you must be running the registry on port 5001 to push to 5001, if you already had a registry running on the previous 5000 then continue pushing on 5000, or else recreate the entire setup (delete the registry container and clusters, use the updated script). |
ref: #1213 (comment)
pair programmed with @BenTheElder and figured this out
/cc @BenTheElder