Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChromeOS needs KubeletInUserNamespace #3101

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

dex4er
Copy link
Contributor

@dex4er dex4er commented Feb 16, 2023

I can run KIND cluster in ChromeOS sucesfully with this instruction. Actually it is not a specific to ChromeOS but it will be the same for running KIND in just any LXC container.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 16, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dex4er / name: Piotr Roszatycki (468b9aa)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 16, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @dex4er!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 16, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @dex4er. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 16, 2023
@aojea
Copy link
Contributor

aojea commented Feb 16, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 16, 2023
@stmcginnis
Copy link
Contributor

/lgtm

I have not tested and do not have a way to easily do so, but it looks like everything necessary is added and if the submitter has tested and it works for them, that's good enough for me.

One caveat I'm thinking here - should we have a statement in the docs that this is an experimental or "unsupported" use case? Great that this works and is an option for folks, but I think it strays a little outside the primary scope of the project.

In other words, it might be good to make it clear that the maintainers won't spend a lot of time troubleshooting if a user files an issue having a problem running on ChromeOS.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2023
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thank you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dex4er

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit b3d74a3 into kubernetes-sigs:main Feb 16, 2023
@BenTheElder
Copy link
Member

That's a good point @stmcginnis but we're also not currently requiring that for say, https://kind.sigs.k8s.io/docs/user/using-wsl2/ even though those docs are entirely user-contributed and not something we test (#1529). Docker Desktop on macOS is in a similar state currently as well of supported-but-not-actively-tested and only best-effort back and forth debugging via github.

@dex4er
Copy link
Contributor Author

dex4er commented Feb 16, 2023

I see the difference between "unsupported" and "not working". I can thank you that you added the description of how to start KIND in LXC or ChromeOS even if I don't expect you can't troubleshoot such a setup.

@dex4er dex4er deleted the dex4er/chromeos branch February 17, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants