-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChromeOS needs KubeletInUserNamespace #3101
Conversation
|
Welcome @dex4er! |
Hi @dex4er. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm I have not tested and do not have a way to easily do so, but it looks like everything necessary is added and if the submitter has tested and it works for them, that's good enough for me. One caveat I'm thinking here - should we have a statement in the docs that this is an experimental or "unsupported" use case? Great that this works and is an option for folks, but I think it strays a little outside the primary scope of the project. In other words, it might be good to make it clear that the maintainers won't spend a lot of time troubleshooting if a user files an issue having a problem running on ChromeOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, dex4er The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
That's a good point @stmcginnis but we're also not currently requiring that for say, https://kind.sigs.k8s.io/docs/user/using-wsl2/ even though those docs are entirely user-contributed and not something we test (#1529). Docker Desktop on macOS is in a similar state currently as well of supported-but-not-actively-tested and only best-effort back and forth debugging via github. |
I see the difference between "unsupported" and "not working". I can thank you that you added the description of how to start KIND in LXC or ChromeOS even if I don't expect you can't troubleshoot such a setup. |
I can run KIND cluster in ChromeOS sucesfully with this instruction. Actually it is not a specific to ChromeOS but it will be the same for running KIND in just any LXC container.