Node-image: tag the core bundled images that we want to preserve with a pinned label

[roman-kiselenko]

Ref #3441

Tag the core bundled images with pinned label.

crictl inspecti registry.k8s.io/coredns/coredns:v1.11.1
{
  "status": {
    "id": "sha256:2437cf762177702dec2dfe99a09c37427a15af6d9a57c456b65352667c223d93",
    "repoTags": [
      "registry.k8s.io/coredns/coredns:v1.11.1"
    ],
    "repoDigests": [],
    "size": "16482581",
    "uid": null,
    "username": "nonroot",
    "spec": null,
    "pinned": true
  },

Additional context

• prevents garbage collection from removing pinned images kubernetes/kubernetes#103299
• CRI Pinned image support containerd/containerd#7944

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: roman-kiselenko / name: Roman Kiselenko (56a52ba)

[k8s-ci-robot]

Welcome @roman-kiselenko!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @roman-kiselenko. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[neolit123]

is the pin feature even working properly at this point? this is a recent bug fix PR in containerd:
containerd/containerd#9328

i don't think we need to pin any image of active installed components - i.e. if we run a static pod, the image is "active", same goes for the deployments and DS-es that kubeadm / kind deploy.

[BenTheElder]

is the pin feature even working properly at this point? this is a recent bug fix PR in containerd:

I know it's rolling out to another distro, even if not AFAICT it's not doing anything actively harmful in the bugs.

We aren't ready to re-enable GC by default yet without further conversation anyhow, but we can go ahead and start labeling these.

i don't think we need to pin any image of active installed components - i.e. if we run a static pod, the image is "active", same goes for the deployments and DS-es that kubeadm / kind deploy.

It's a layering violation to try to know which ones are currently run as static pods are not, it makes sense to just label all of the images we pre-loaded because they may not be pullable in the target environment and we're expressing intent that they should not be GCed.

[BenTheElder]

/lgtm
/approve

thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, roman-kiselenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@roman-kiselenko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kind-e2e-kubernetes-1-24	56a52ba	link	true	/test pull-kind-e2e-kubernetes-1-24

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.