remove generated base image sources #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/L
pkg/build/base/base.go
Outdated
| if err != nil { | ||
| return err | ||
| return fmt.Errorf("failed to locate sources: %v", err) |
There was a problem hiding this comment.
maybe using errors instead of fmt.
There was a problem hiding this comment.
done, also updated the docs
BenTheElder
force-pushed
the
less-generated
branch
from
1010015 to
5319fe3
Compare
|
updated the docs, includes minor updates related to #485 as well as the changes here |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
stg-0
pushed a commit
to stg-0/kind
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #488
EDIT: also #485, we can't find a good lower bound for docker for desktop because it appears to be lower than the settings offer, but we can stop suggesting that it is 4 core / 4 cpu unless you are building kubernetes.