Fix errors #494
Merged
Fix errors #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/cc @BenTheElder |
6 tasks
BenTheElder
reviewed
May 6, 2019
Co-Authored-By: mkumatag <[email protected]>
|
wow... one click on suggestion button helped me merge @BenTheElder changes, nice GitHub feature. ptal latest changes. |
BenTheElder
approved these changes
May 6, 2019
| mount -o ro,bind /kind/product_name /sys/class/dmi/id/product_name | ||
| if [[ -f /sys/class/dmi/id/product_name ]]; then | ||
| echo "kind" > /kind/product_name | ||
| mount -o ro,bind /kind/product_name /sys/class/dmi/id/product_name |
There was a problem hiding this comment.
Note to self: consider always faking the entire DMI decode VFS
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
stg-0
added a commit
to stg-0/kind
that referenced
this pull request
Mar 4, 2024
Co-authored-by: stg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #493
Code reused from - https://github.com/kubernetes-sigs/kubeadm-dind-cluster/blob/master/image/rundocker#L80:L83