Skip to content

Watch features.d changes #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tkatila opened this issue Mar 7, 2025 · 1 comment · May be fixed by #2156
Open

Watch features.d changes #2075

tkatila opened this issue Mar 7, 2025 · 1 comment · May be fixed by #2156
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@tkatila
Copy link
Contributor

tkatila commented Mar 7, 2025

What would you like to be added:

Changes in the label files in the features.d directory are now propagated every sleep-interval. I'd like to have it so that NFD worker watches the features.d directory and runs the labeling procedure on every change.

Why is this needed:

We have a use case where a workload requires additional node configuration on top of an extended resource (device plugin). The workload is structured so that a container requests an extended resource and is nodeSelector limited to nodes with a special "configuration complete" label. With the default 60sec sleep duration, there is an additional 1-59 sec delay before the workload is scheduled to a node. For the labels to appear quicker to nodes would make them more convenient to control scheduling.
@tkatila tkatila added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 7, 2025
@marquiz
Copy link
Contributor

marquiz commented Mar 12, 2025

Thanks @tkatila for the proposal. I think this makes sense. It could also make it sligthly less racy if we rely on fsnotify events instead of a fixed interval there.

@ozhuraki ozhuraki linked a pull request May 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nfd-worker: Watch features.d changes ozhuraki/node-feature-discovery
2 participants
@marquiz @tkatila