Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.3.0: Release tracking #430

Closed
3 tasks done
justaugustus opened this issue Sep 15, 2021 · 1 comment
Closed
3 tasks done

v3.3.0: Release tracking #430

justaugustus opened this issue Sep 15, 2021 · 1 comment
Assignees
@justaugustus
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@justaugustus
Copy link
Contributor

justaugustus commented Sep 15, 2021 •
edited
Loading

What would you like to be added:

Tracking some cleanup tasks we'll want to get into the next release...

Why is this needed:

NO LONGER REQUIRED -- Allow imports again

(Cut a v3.2.1 which fixes this: https://github.com/kubernetes-sigs/promo-tools/releases/tag/v3.2.1)

Following the repo rename in #424, I wanted to importing the new module in k/release and 👇🏾:

❯ go mod tidy
go: finding module for package sigs.k8s.io/promo-tools/v3/legacy/dockerregistry
go: downloading sigs.k8s.io/promo-tools v1.339.0
go: downloading sigs.k8s.io/promo-tools/v3 v3.2.0
go: found sigs.k8s.io/promo-tools/v3/legacy/dockerregistry in sigs.k8s.io/promo-tools/v3 v3.2.0
go: k8s.io/release/cmd/krel/cmd imports
	sigs.k8s.io/promo-tools/v3/legacy/dockerregistry: sigs.k8s.io/promo-tools/[email protected]: parsing go.mod:
	module declares its path as: sigs.k8s.io/k8s-container-image-promoter/v3
	        but was required as: sigs.k8s.io/promo-tools/v3

❯ go get sigs.k8s.io/promo-tools/[email protected]
go get: sigs.k8s.io/promo-tools/[email protected]: parsing go.mod:
	module declares its path as: sigs.k8s.io/k8s-container-image-promoter/v3
	        but was required as: sigs.k8s.io/promo-tools/v3

I'm really hoping this will be tolerant of a new minor release and not require a v4 module to overcome...

/assign
cc: @kubernetes-sigs/release-engineering
@justaugustus justaugustus added kind/feature Categorizes issue or PR as related to a new feature. wg/k8s-infra sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Sep 15, 2021
@justaugustus justaugustus changed the title v3.3.0: Release tracking v3.2.2: Release tracking Sep 15, 2021
@justaugustus justaugustus changed the title v3.2.2: Release tracking v3.3.0: Release tracking Sep 26, 2021
@justaugustus justaugustus mentioned this issue Sep 27, 2021
Merged
@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. and removed wg/k8s-infra labels Sep 30, 2021
@justaugustus
Copy link
Contributor Author

Release: https://github.com/kubernetes-sigs/promo-tools/releases/tag/v3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justaugustus justaugustus

Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justaugustus @k8s-ci-robot