old (beta) topology labels are going away

[thockin]

Hello.

The labels failure-domain.beta.kubernetes.io/zone and failure-domain.beta.kubernetes.io/region have been deprecated for almost a year now and are scheduled to be removed from kubernetes/kubernetes after 1.20 (Q1'21).

In prep for that I scanned all our repos looking for places that reference the old names and not the new ones. There are a couple such places in this repo. Without knowing exactly what this codebase is doing, I can't say for sure if it is a problem or not, so I am just filing issues.

Please take a look and be advised of this upcoming change.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[thockin]

/lifecycle frozen
/remove-lifecycle stale
/remove-lifecycle rotten

[alx13]

Already hit this issue, I tried to use topology.kubernetes.io/zone for a nodeSelector on EKS 1.18

If autoscaling group have no instances at the moment and you are deploying a pod with this selector, cluster-autoscaler will not scale ASG from 0, because it's not aware of the new labels.

https://github.com/kubernetes/api/blob/v0.20.4/core/v1/well_known_labels.go#L24

autoscaler/cluster-autoscaler/cloudprovider/aws/aws_manager.go

Line 390 in 99936f3

func buildGenericLabels(template *asgTemplate, nodeName string) map[string]string {