-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of Capabilities.KubeVersion so we do not need to override image.tag in Helm Values #5324
Comments
@miroljub1995 Looks like cool feature, but the KubeVersion will not necessary match the autoscaler image tag. |
@gjtempleton your thoughts on this? |
if this seems valid, then I will give it a try. |
Hey, thanks for the suggestion, as @khizunov says, the KubeVersion won't necessarily match the image tag, particularly the patch version, as well as the lag between a new minor release of k8s being cut and the relevant CA image being released/promoted. If we were to support this, I certainly wouldn't want it being the default behaviour unless we had a reliable way of fetching the latest patch release for the detected minor version and using that as an input. |
Hi @gjtempleton
Could you please give any pointer or lead on how we can proceed with this? |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Hi @gjtempleton Is there any way or pointer to start with this? Also, we need the same minor version of k8s for CA, but there is always a delay in the release of the CA corresponding to the k8s release and it affects the chart version. we have to consider this thing also. suppose a user uses the new release of k8s but we would not have the corresponding release of CA at that time so what version it would consider for CA? |
@gjtempleton, your thoughts on the above comment? |
Hi @gjtempleton PTAL! |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
@gjtempleton, could you please take a look at this? Thanks! |
IMO, making image.tag version as same as the Kubernetes Version is not feasible because the minor or patch version for the CA chart is not always the same as the Kube version. Minor/Patch version (as per changes) for the charts is released after every change in the charts. |
cc @gjtempleton, PTAL! |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
cc @gjtempleton, could you please take a look? /lifecycle frozen |
Which component are you using?:
cluster-autoscaler (helm)
Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
no
Describe the solution you'd like.:
It would be great if image tag could be inferred based on Capabilities.KubeVersion so that we do not need to override image.tag in Chart Values. Right now default tag is v1.23.0, but if we run on k8s v1.24, we need to override it to v1.24.0.
Describe any alternative solutions you've considered.:
The only alternative way is to set image.tag explicitly.
The text was updated successfully, but these errors were encountered: