Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPA release 1.0.0 #6113

Closed
raywainman opened this issue Sep 15, 2023 · 17 comments
Closed

VPA release 1.0.0 #6113

raywainman opened this issue Sep 15, 2023 · 17 comments

Comments

@raywainman
Copy link
Contributor

Following instructions in RELEASE.md.

Starting this release as recommended by @jbartosik. This corresponds to the k8s 1.28 release.

Please provide any information that is related to the release:

  • When we plan to do the release?
    • Now
  • Are there any issues / PRs blocking the release?
    • TBD
@raywainman
Copy link
Contributor Author

raywainman commented Sep 15, 2023

Current VPA tests are all green - https://testgrid.k8s.io/sig-autoscaling-vpa

@aadyyb
Copy link

aadyyb commented Sep 18, 2023

is there a plan to publish an official helm chart? There is issue open (#5369) with reference to a few of community options, but we are challenged by our security to use 'unofficial' helm chart.

@jbartosik
Copy link
Collaborator

is there a plan to publish an official helm chart? There is issue open (#5369) with reference to a few of community options, but we are challenged by our security to use 'unofficial' helm chart.

Like I mentioned in a comment on the issue I think we can accept contributions but don't have capacity to maintain them.

As far as I know none contributed helm charts for VPA specifically (one can use CA helm chart to deploy VPA).

@jbartosik
Copy link
Collaborator

I created new branch: https://github.com/kubernetes/autoscaler/tree/vpa-release-1.0

BTW we should update release documentation to refer to 1.n instead of 0.n from now on

@raywainman
Copy link
Contributor Author

Thanks @jbartosik.

New images are available in gcr.io/k8s-staging-autoscaling (thanks Joachim for the help there as well).

Moving onto the testing portion.

@raywainman
Copy link
Contributor Author

Ran into #6141 as part of this release

@raywainman
Copy link
Contributor Author

raywainman commented Sep 26, 2023

Tests passing:

Ran 5 of 304 Specs in 1968.220 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 299 Skipped
--- PASS: TestE2E (1968.23s)
PASS
ok  	command-line-arguments	1968.575s
~/kubernetes/src/k8s.io/autoscaler/vertical-pod-autoscaler
v1beta2 test result: 0
v1 test result: 0

@raywainman
Copy link
Contributor Author

Image is promoted:

$ gcloud container images describe registry.k8s.io/autoscaling/vpa-recommender:1.0.0
WARNING: Successfully resolved tag to sha256, but it is recommended to use sha256 directly.
image_summary:
  digest: sha256:bc0bd96faf0e4845afe653a2692cfcb34c47b7a9ec5d0ab330fec5160c21e963
  fully_qualified_digest: registry.k8s.io/autoscaling/vpa-recommender@sha256:bc0bd96faf0e4845afe653a2692cfcb34c47b7a9ec5d0ab330fec5160c21e963
  registry: registry.k8s.io
  repository: autoscaling/vpa-recommender

@Shubham82
Copy link
Contributor

Shubham82 commented Sep 28, 2023

I think we have to backport #6151 into vpa-release-1.0 branch
@raywainman @jbartosik WDYT?

If seems good then I will open a PR for it.

@raywainman
Copy link
Contributor Author

@Shubham82 seems totally reasonable, sgtm

@raywainman
Copy link
Contributor Author

Ran tests again in a new 1.24 cluster as an extra check:

Ran 5 of 304 Specs in 2070.751 seconds
SUCCESS! -- 5 Passed | 0 Failed | 0 Pending | 299 Skipped
--- PASS: TestE2E (2070.76s)
PASS
ok  	command-line-arguments	2071.122s
~/kubernetes/src/k8s.io/autoscaler/vertical-pod-autoscaler
v1beta2 test result: 0
v1 test result: 0

@Shubham82
Copy link
Contributor

@Shubham82 seems totally reasonable, sgtm

Thanks @raywainman, will raise PR soon.

@Shubham82
Copy link
Contributor

@Shubham82 seems totally reasonable, sgtm

Thanks @raywainman, will raise PR soon.

Fixed it here: #6160

@Ubun1
Copy link

Ubun1 commented Oct 9, 2023

hi all!
Can someone compile changelog with user facing features for 1.0.0 release ?

@jbartosik
Copy link
Collaborator

Yes, we're going to. It's taking a bit longer than I expected, sorry about that.

@raywainman
Copy link
Contributor Author

Apologies for the delay here team. I've compiled the following release notes:


What's Changed

Full Changelog

https://github.com/kubernetes/autoscaler/compare/vertical-pod-autoscaler-0.14.0..vertical-pod-autoscaler-1.0.0


@jbartosik can you please help me with the remaining steps in https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/RELEASE.md#finalize-release?

Thanks so much!

@kwiesmueller
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants