Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPA Improving Flags Documentation Generation Process #7779

Open
omerap12 opened this issue Jan 29, 2025 · 5 comments · May be fixed by #7811
Open

VPA Improving Flags Documentation Generation Process #7779

omerap12 opened this issue Jan 29, 2025 · 5 comments · May be fixed by #7811
Assignees
Labels
area/vertical-pod-autoscaler good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.

Comments

@omerap12
Copy link
Member

Currently, the process for generating the flags documentation for the VPA involves running the script: vertical-pod-autoscaler/hack/create-flags-doc-vpa.sh. This script triggers make document-flags in each VPA component and then combines the output into a single file: vertical-pod-autoscaler/docs/flags.md.

While this method works, we’d like to improve it by adopting a more streamlined approach similar to how the cluster-autoscaler generates its flags documentation. Specifically, we want to leverage the flags package’s auto-generated documentation by simply calling the binaries.

For reference: #7642 (comment)

I’ve made some progress on this, but any additional help would be appreciated (feel free to assign it to yourself).

/assign
/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 29, 2025
@omerap12
Copy link
Member Author

/kind good-first-issue

@k8s-ci-robot
Copy link
Contributor

@omerap12: The label(s) kind/good-first-issue cannot be applied, because the repository doesn't have them.

In response to this:

/kind good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@omerap12
Copy link
Member Author

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@omerap12:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 29, 2025
@adrianmoisey
Copy link
Member

/area vertical-pod-autoscaler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants