Skip to content

Commit a57711e

Browse files
authored
Merge pull request #5657 from matthyx/4188
KEP-4188: post merge PRR nits
2 parents f70eaa6 + ef6905a commit a57711e

File tree

1 file changed

+6
-2
lines changed
  • keps/sig-node/4188-kubelet-pod-readiness-api

1 file changed

+6
-2
lines changed

keps/sig-node/4188-kubelet-pod-readiness-api/README.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ The API becomes available again. The API is stateless, so no recovery is needed,
389389

390390
###### Are there any tests for feature enablement/disablement?
391391

392-
yes, test will demonstrate that when the feature gate is disabled, the API returns the appropriate error code.
392+
Yes, test will demonstrate that when the feature gate is disabled, the API returns the appropriate error code.
393393

394394
### Rollout, Upgrade and Rollback Planning
395395

@@ -403,6 +403,7 @@ Kubelet may fail to start. The new API may cause the Kubelet to crash.
403403

404404
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
405405

406+
N/A.
406407

407408
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
408409

@@ -415,7 +416,10 @@ No.
415416
Look at the `pod_info_endpoint_requests_list`, `pod_info_endpoint_requests_get`, `pod_info_endpoint_requests_watch` metric exposed by the Kubelet.
416417

417418
###### How can someone using this feature know that it is working for their instance?
418-
Log entry indicating that API is ready to received the traffic will be added.
419+
420+
Access the API - it should return the Pod information.
421+
422+
Log entry indicating that API is ready to receive the traffic will be added.
419423

420424
- [ ] Events
421425
- Event Reason:

0 commit comments

Comments
 (0)