Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive Read-only (RRO) mounts #3857

Open
16 of 19 tasks
AkihiroSuda opened this issue Feb 8, 2023 · 59 comments
Open
16 of 19 tasks

Recursive Read-only (RRO) mounts #3857

AkihiroSuda opened this issue Feb 8, 2023 · 59 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Feb 8, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 8, 2023
@AkihiroSuda
Copy link
Member Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 8, 2023
@SergeyKanzhelev
Copy link
Member

adding sig storage as participating sig

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label May 5, 2023
@SergeyKanzhelev
Copy link
Member

@AkihiroSuda do you want to target this KEP for 1.28?

@AkihiroSuda
Copy link
Member Author

@AkihiroSuda do you want to target this KEP for 1.28?

Not necessary.

@AkihiroSuda AkihiroSuda changed the title Recursively Read-only (RRO) hostPath mounts Recursively Read-only (RRO) mounts May 30, 2023
@AkihiroSuda AkihiroSuda changed the title Recursively Read-only (RRO) mounts Recursive Read-only (RRO) mounts Jun 2, 2023
@thockin thockin moved this to Pre-alpha in KEPs I am tracking Jun 2, 2023
@AkihiroSuda
Copy link
Member Author

@kubernetes/sig-node-leads
Any chance to get this lead-opted-in for v1.29?

@AkihiroSuda
Copy link
Member Author

ping @kubernetes/sig-node-leads 🙏

@AkihiroSuda
Copy link
Member Author

@kubernetes/sig-node-leads
Will this be considered for lead-opted-in in the v1.30 milestone?

@AkihiroSuda
Copy link
Member Author

cc @mrunalp @derekwaynecarr @dchen1107 @SergeyKanzhelev for the question above about v1.30 milestone

@pacoxu
Copy link
Member

pacoxu commented Oct 16, 2023

+1 for v1.30

  • We may tag this as v1.30 and get some early input.

adding sig storage as participating sig

@SergeyKanzhelev do we have to check with sig storage leads about this KEP?

@AkihiroSuda
Copy link
Member Author

@mrunalp @derekwaynecarr @dchen1107 @SergeyKanzhelev

PTAL.
If this KEP isn't going to be accepted, I'll just modify the default behavior of containerd to treat "readonly" as "recursive readonly".
Small portion of users may find this to be a breaking change, but probably this is subtle enough.
#3858 (comment)

@carlory
Copy link
Member

carlory commented Jan 17, 2024

@SergeyKanzhelev added sig storage as participating sig for this KEP. The proposal makes sense to me, but I still want to hear from the sig storage members. cc @jsafrane @msau42 @xing-yang Can you please review the proposal and provide your feedback? Thanks! If accepted, this KEP may be able to have an alpha implement in 1.30.

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Jan 30, 2024

Didn't get lead-opted-in. Giving up.

Alternative:

@AkihiroSuda AkihiroSuda closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
@AkihiroSuda
Copy link
Member Author

Reopening

#3858 (comment)

@mrunalp
Copy link
Contributor

mrunalp commented Feb 5, 2024

/milestone 1.30
/stage alpha
/label lead-opted-in

@k8s-ci-robot
Copy link
Contributor

@mrunalp: The provided milestone is not valid for this repository. Milestones in this repository: [v1.25, v1.27, v1.28, v1.29, v1.30, v1.31]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.30
/stage alpha
/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 5, 2024
@tjons
Copy link
Contributor

tjons commented Sep 16, 2024

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

@haircommander
Copy link
Contributor

@AkihiroSuda are you planning on pushing this forward in 1.33?

@AkihiroSuda
Copy link
Member Author

@AkihiroSuda are you planning on pushing this forward in 1.33?

I'm not sure.

The original criteria to graduate this from Beta was:

#### GA
- Two beta releases of Kubernetes at least
- containerd, CRI-O, and cri-dockerd supports the feature with their GA releases

However, cri-dockerd with this feature is still not released, although the feature has been implemented in its master branch.

Can we just skip cri-dockerd?

@haircommander
Copy link
Contributor

Can we just skip cri-dockerd?

yeah our guidance now is containerd and cri-o are required kubernetes/contributor-site#566 . SIG node would be open to additional runtimes but the expectation is they participate more in the SIG to block the progress of features

@AkihiroSuda
Copy link
Member Author

The test (https://github.com/kubernetes/kubernetes/blob/v1.33.0-alpha.1/test/e2e_node/mount_rro_linux_test.go) seems still skipped in ci-kubernetes-e2e-kind-beta-features, although the kind nodes has been updated to use containerd v2. 🤔

https://storage.googleapis.com/kubernetes-ci-logs/logs/ci-kubernetes-e2e-kind-beta-features/1887785121608634368/artifacts/junit_01.xml

The graduation might need to be postponed to v1.34.

@AkihiroSuda
Copy link
Member Author

@AkihiroSuda
Copy link
Member Author

@soltysh
Copy link
Contributor

soltysh commented Feb 10, 2025

Proposal: promote to GA

* [KEP-3857: Recursive Read-only (RRO) mounts: promote to GA #5157](https://github.com/kubernetes/enhancements/pull/5157)

I'll take a look from PRR perspective, but you need to ping sig-node leads to get this included in 1.33 release, it is not currently.

@AkihiroSuda
Copy link
Member Author

ping @kubernetes/sig-node-leads

@haircommander
Copy link
Contributor

/label lead-opted-in
/milestone v1.33

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.31, v1.33 Feb 10, 2025
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 10, 2025
@jenshu
Copy link

jenshu commented Feb 10, 2025

Hello @AkihiroSuda 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage stable for v1.33 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • In the kep.yaml, the latest-milestone needs to be updated to v1.33
  • In the PRR file, an approver for stable needs to be listed. Once your PR merges, both of these should be resolved.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@jenshu jenshu moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Feb 10, 2025
@haircommander haircommander moved this from Triage to Proposed for consideration in SIG Node 1.33 KEPs planning Feb 11, 2025
@jenshu
Copy link

jenshu commented Feb 13, 2025

Hello @AkihiroSuda 👋, v1.33 Enhancements team here.

With all the requirements fulfilled, this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@jenshu jenshu moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.33 Enhancements Tracking Feb 13, 2025
@haircommander haircommander moved this from Proposed for consideration to Tracked in SIG Node 1.33 KEPs planning Feb 13, 2025
@rayandas
Copy link
Member

Hello @AkihiroSuda 👋, v1.33 Docs Lead here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@AkihiroSuda
Copy link
Member Author

@rayandas
Copy link
Member

Thanks @AkihiroSuda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked for Doc Freeze
Status: Tracked for enhancements freeze
Status: Tracked
Status: Tracked for Doc Freeze
Status: Not for release
Development

No branches or pull requests