Skip to content

Conversation

@Gacko
Copy link
Member

@Gacko Gacko commented Dec 5, 2025

/triage accepted
/kind cleanup
/priority backlog
/cc @cpanato @strongjz @tao12345666333
/hold

Copilot AI review requested due to automatic review settings December 5, 2025 23:10
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2025
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates Helm from v3.19.2 to v4.0.1, which is a major version upgrade.

Key Changes:

  • Updates Helm version references in CI/CD workflows, Makefiles, and tool configuration
  • Updates Go module dependencies for Helm v4
  • Changes import path for Helm chartutil package

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
magefiles/steps/helm.go Updates import path for chartutil from v3 to v4 (contains incorrect path)
images/test-runner/Makefile Updates HELM_VERSION build argument from 3.19.2 to 4.0.1
hack/.tool-versions Updates helm tool version from 3.19.2 to 4.0.1
go.sum Updates go.sum with new Helm v4 module checksums and removes obsolete dependencies
go.mod Updates helm.sh/helm dependency from v3.19.2 to v4.0.1 and removes indirect dependencies
charts/Makefile Updates helm installation command to use v4 module path
.github/workflows/ci.yaml Updates Helm version in CI workflow from v3.19.2 to v4.0.1
.github/workflows/chart.yaml Updates Helm version in chart workflow from v3.19.2 to v4.0.1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2025
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Gacko, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Gacko,cpanato,tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants