Skip to content

Conversation

minikube-bot
Copy link
Collaborator

The ingress-nginx project released a new version

This PR was auto-generated by make update-ingress-version using update-ingress-version.yml CI Workflow.

@minikube-bot minikube-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 6, 2025
@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from 2484023 to 21a8774 Compare January 6, 2025 10:03
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2025
@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from 21a8774 to ec988a7 Compare January 13, 2025 10:03
@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from ec988a7 to e6a8cea Compare January 20, 2025 10:03
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from e6a8cea to 305c523 Compare January 27, 2025 10:03
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from 305c523 to 61af644 Compare February 3, 2025 10:03
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from 61af644 to 486452f Compare February 10, 2025 10:03
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from 486452f to 92f8fd4 Compare February 17, 2025 10:03
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from 92f8fd4 to f91e5eb Compare February 24, 2025 10:03
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from f91e5eb to a00253a Compare March 3, 2025 10:03
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from b3b3344 to c354b3d Compare March 24, 2025 10:03
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from c354b3d to 3c2c196 Compare March 31, 2025 10:03
@minikube-bot minikube-bot changed the title Addon ingress: Update ingress-nginx/controller image from v1.11.3 to v1.12.0 Addon ingress: Update ingress-nginx/controller image from v1.11.3 to v1.12.1 Mar 31, 2025
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@khumps
Copy link

khumps commented Apr 1, 2025

There is a CVE patched by 1.12.1

#20578

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from 3c2c196 to fd0facd Compare April 7, 2025 10:03
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from fd0facd to 6e9b07a Compare April 14, 2025 10:03
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Windows (2 failed) TestErrorSpam/setup(gopogh) Unknown
Docker_Windows (2 failed) TestStartStop/group/old-k8s-version/serial/SecondStart(gopogh) Unknown
Docker_Linux_crio (2 failed) TestFunctional/parallel/ImageCommands/ImageListShort(gopogh) 0.00% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from 6e9b07a to 6ec003d Compare April 21, 2025 10:03
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minikube-bot
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from 6ec003d to 7a7f4cb Compare April 28, 2025 10:37
@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from 7a7f4cb to af547cc Compare May 5, 2025 10:03
@minikube-bot minikube-bot changed the title Addon ingress: Update ingress-nginx/controller image from v1.11.3 to v1.12.1 Addon ingress: Update ingress-nginx/controller image from v1.11.3 to v1.12.2 May 5, 2025
@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_ingress_version branch from af547cc to f9f36c9 Compare May 12, 2025 10:03
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20201) |
+----------------+----------+---------------------+
| minikube start | 53.3s    | 55.1s               |
| enable ingress | 18.6s    | 16.8s               |
+----------------+----------+---------------------+

Times for minikube start: 52.2s 52.5s 54.2s 54.4s 53.2s
Times for minikube (PR 20201) start: 55.8s 57.4s 51.6s 55.4s 55.1s

Times for minikube ingress: 18.6s 16.3s 19.2s 19.7s 19.2s
Times for minikube (PR 20201) ingress: 16.2s 15.7s 15.7s 16.1s 20.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20201) |
+----------------+----------+---------------------+
| minikube start | 24.5s    | 24.8s               |
| enable ingress | 12.8s    | 13.1s               |
+----------------+----------+---------------------+

Times for minikube start: 24.3s 24.5s 25.4s 24.2s 23.9s
Times for minikube (PR 20201) start: 24.6s 23.7s 24.2s 24.0s 27.4s

Times for minikube ingress: 12.4s 12.8s 12.9s 13.4s 12.4s
Times for minikube (PR 20201) ingress: 12.4s 12.4s 13.3s 13.8s 13.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20201) |
+----------------+----------+---------------------+
| minikube start | 25.2s    | 23.4s               |
| enable ingress | 23.1s    | 25.3s               |
+----------------+----------+---------------------+

Times for minikube start: 25.6s 23.5s 26.1s 24.5s 26.1s
Times for minikube (PR 20201) start: 22.7s 21.8s 22.9s 24.7s 24.8s

Times for minikube ingress: 22.9s 22.9s 22.8s 23.9s 22.9s
Times for minikube (PR 20201) ingress: 27.8s 22.9s 22.9s 29.8s 22.9s

@medyagh
Copy link
Member

medyagh commented May 13, 2025

clean up duplicates

@medyagh medyagh closed this May 13, 2025
@andrewspiers
Copy link

Hi @medyagh is there a PR that duplicates this one? I see the linked issue #20578 still open, and I think the original reason, a security issue in versions of ingress, is still valid. See for example
https://www.cyber.gov.au/about-us/view-all-content/alerts-and-advisories/critical-vulnerabilities-ingress-nginx-controller-kubernetes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants