-
Notifications
You must be signed in to change notification settings - Fork 5.1k
ci: Added docker-containerd-linux-x86-64 tests to prow #21974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Added docker-containerd-linux-x86-64 tests to prow #21974
Conversation
|
Hi @divysinghvi. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
Can one of the admins verify this patch? |
This comment has been minimized.
This comment has been minimized.
|
/retest |
This comment has been minimized.
This comment has been minimized.
|
/retest |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/retest |
0a13bf6 to
f30d0b9
Compare
|
/retest |
This comment has been minimized.
This comment has been minimized.
e919643 to
5bc9857
Compare
This comment has been minimized.
This comment has been minimized.
5bc9857 to
7124b09
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
53645b2 to
055c5fe
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pkg/minikube/cruntime/containerd.go
Outdated
| } | ||
|
|
||
| // setContainerdUlimit sets LimitNOFILE for containerd to match docker's default ulimit | ||
| func setContainerdUlimit(cr CommandRunner) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we are adding this to the kicbase this code wont be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we won't need if we are updating the kicbase image i did not knew how the kickbase image update worked
|
|
||
| # Set ulimit for containerd to match docker's default-ulimit setting | ||
| # This ensures consistent file descriptor limits (1048576) across container runtimes | ||
| RUN sed -i '/^\[Service\]/a LimitNOFILE=1048576' /lib/systemd/system/containerd.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want this change plz ask one of the maintainers to run
ok-to-build-image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you run ok-to-build-image sorry i am still confused about the process
This comment has been minimized.
This comment has been minimized.
|
ok-to-build-image |
|
Hi @divysinghvi, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
kvm2 driver with docker runtime Times for minikube start: 39.2s 40.9s 40.1s 40.4s 44.5s Times for minikube ingress: 15.8s 15.7s 15.2s 14.7s 15.2s docker driver with docker runtime Times for minikube start: 22.8s 22.0s 21.1s 24.2s 21.5s Times for minikube ingress: 12.6s 10.6s 10.6s 10.6s 10.6s docker driver with containerd runtime Times for minikube start: 22.0s 21.7s 21.6s 22.7s 20.4s Times for minikube ingress: 20.1s 21.1s 20.1s 20.1s 20.1s |
|
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ComradeProgrammer, divysinghvi, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@divysinghvi: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Added integration-prow-docker-containerd-linux-x86-64 prow test
issue : #21916