Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable kind at prow preset #11510

Merged
merged 2 commits into from
Feb 26, 2019
Merged

enable kind at prow preset #11510

merged 2 commits into from
Feb 26, 2019

Conversation

figo
Copy link
Contributor

@figo figo commented Feb 26, 2019

there are a few mount needed in order for kind run at Prow works, kubernetes-sigs/kind#303

this is to add preset for that, also this PR is on top of #11509

/cc @BenTheElder

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2019
and enable it for cluster-api integration test
@k8s-ci-robot k8s-ci-robot added the area/prow Issues or PRs related to prow label Feb 26, 2019
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b2bda6ca1d893aa82be80a8267051278e6f7ad0b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, figo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5f3bcc8 into kubernetes:master Feb 26, 2019
@k8s-ci-robot
Copy link
Contributor

@figo: Updated the following 2 configmaps:

  • job-config configmap in namespace default using the following files:
    • key cluster-api-ci.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-ci.yaml
    • key cluster-api-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits.yaml
  • config configmap in namespace default using the following files:
    • key config.yaml using file prow/config.yaml

In response to this:

there are a few mount needed in order for kind run at Prow works, kubernetes-sigs/kind#303

this is to add preset for that, also this PR is on top of #11509

/cc @BenTheElder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants