-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prow cluster: create loop devices in advance #16212
Conversation
This is a workaround for dynamic device creation not working inside KinD nodes.
I have verified that:
I have not verified that this really works in the Kubernetes prow. I'm not even sure whether the daemonset will be deployed automatically? I modeled this after https://github.com/kubernetes/test-infra/blob/b2d632960440e47f671dd3b997709aa299911456/prow/cluster/tune-sysctls_daemonset.yaml. /cc @BenTheElder |
it can be deployed if added to the bazel rules for deploying prow, see 75edf5a#diff-f677234fb7028152fac5bac409d77567 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a workaround for dynamic device creation not working inside
KinD nodes.
Fixes: kubernetes-sigs/kind#1248 kubernetes/kubernetes#87953