Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow cluster: create loop devices in advance #16212

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Feb 10, 2020

This is a workaround for dynamic device creation not working inside
KinD nodes.

Fixes: kubernetes-sigs/kind#1248 kubernetes/kubernetes#87953

This is a workaround for dynamic device creation not working inside
KinD nodes.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 10, 2020
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 10, 2020
@pohly
Copy link
Contributor Author

pohly commented Feb 10, 2020

I have verified that:

  • Deploying this daemonset on a normal cluster populates /dev as intended.
  • That the nodes in a KinD cluster with fully populated /dev also then have the same /dev/loopX entries.

I have not verified that this really works in the Kubernetes prow. I'm not even sure whether the daemonset will be deployed automatically?

I modeled this after https://github.com/kubernetes/test-infra/blob/b2d632960440e47f671dd3b997709aa299911456/prow/cluster/tune-sysctls_daemonset.yaml.

/cc @BenTheElder

@BenTheElder
Copy link
Member

it can be deployed if added to the bazel rules for deploying prow, see 75edf5a#diff-f677234fb7028152fac5bac409d77567

@BenTheElder
Copy link
Member

/lgtm
/approve
will do deployment in a follow up
this hack is sorta gross, but also only something we should need, the average KIND user is probably not using block devices ... I hope!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0c94fe1 into kubernetes:master Feb 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/bump Updates to the k8s prow cluster area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

number of loop devices is fixed and unpredictable
3 participants