Skip to content

🐛 fix: prevent release channel publication starvation - #4811

Merged
clubanderson merged 2 commits into
v4from
review/4806-release-channel-starvation
Aug 26, 2026
Merged

🐛 fix: prevent release channel publication starvation#4811
clubanderson merged 2 commits into
v4from
review/4806-release-channel-starvation

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Supersedes #4806 with Danathar’s release-channel starvation fix plus reviewer fix-forward changes.

Adds per-build short-SHA image publication, monotonic moving-tag advancement by workflow run generation, idempotent rerun handling for existing short-SHA tags, and bounded cleanup for old pure short-SHA GHCR versions.

Fixes #4804.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Aug 26, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but does not touch CHANGELOG.md.

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a line under ## Unreleased. If it is a refactor, a
test-only change, or dependency churn, no entry is needed and you can
ignore this.

This is a reminder, not a gate; it never blocks a merge.

@clubanderson
clubanderson force-pushed the review/4806-release-channel-starvation branch 2 times, most recently from f9979f5 to 0450e81 Compare August 26, 2026 17:30
Danathar and others added 2 commits August 26, 2026 13:45
Signed-off-by: Danathar <doug.baggett@gmail.com>
Keep immutable short-SHA image tags immutable across workflow reruns by leaving an existing SHA tag untouched, and only advance moving tags when the current workflow generation is strictly newer.

Add a scheduled GHCR cleanup path for old pure short-SHA versions so per-build tags remain bounded while moving tags and channels stay protected.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the review/4806-release-channel-starvation branch from 0450e81 to cca08d4 Compare August 26, 2026 17:46
@clubanderson
clubanderson merged commit f992bfa into v4 Aug 26, 2026
38 of 39 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the review/4806-release-channel-starvation branch August 26, 2026 18:00
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version badge shows '✓' and '? behind' at the same time when the branch tip has no image

2 participants