Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

governance,community: add job to remove inactive users #3832

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

governance,community: add job to remove inactive users #3832

wants to merge 1 commit into from

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Dec 16, 2024 •
edited
Loading

What this PR does / why we need it:

Adds a job to remove inactive users from the community.

It first runs the contributions generator from k/community, then modifies the orgs.yaml with the result, and lastly generates a PR with the changed file.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

@dhiller
governance: add job to remove inactive users
b49bf02 
Adds a job to remove inactive users from the community.

It first runs the contributions generator from k/community, then
modifies the orgs.yaml with the result, and lastly generates a PR with
the changed file.

Signed-off-by: Daniel Hiller <[email protected]>
@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 16, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from dhiller. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhiller dhiller marked this pull request as ready for review December 16, 2024 17:56
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Dec 16, 2024

Successful test run (no people removed from the org): https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-community-remove-inactive-users-from-orgs-yaml/1868698001782870016

@dhiller
Copy link
Contributor Author

dhiller commented Dec 16, 2024

/cc @EdDev @vladikr

@dhiller dhiller changed the title governance: add job to remove inactive users governance,community: add job to remove inactive users Jan 7, 2025
@dhiller
Copy link
Contributor Author

dhiller commented Feb 12, 2025

🏓 @EdDev @vladikr

EdDev
EdDev approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@EdDev EdDev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry for the late review.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2025
@kubevirt-bot
Copy link
Contributor

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

@kubevirt-bot kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdDev EdDev EdDev approved these changes

@aburdenthehand aburdenthehand Awaiting requested review from aburdenthehand

@xpivarc xpivarc Awaiting requested review from xpivarc

@brianmcarey brianmcarey Awaiting requested review from brianmcarey

@jean-edouard jean-edouard Awaiting requested review from jean-edouard

@vladikr vladikr Awaiting requested review from vladikr

Assignees

@EdDev EdDev

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-approver-review Indicates that a PR requires a review from an approver. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhiller @kubevirt-bot @EdDev