Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidental UT errors #241

Open
Poor12 opened this issue Sep 26, 2023 · 1 comment
Open

Accidental UT errors #241

Poor12 opened this issue Sep 26, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Poor12
Copy link
Collaborator

Poor12 commented Sep 26, 2023

link: https://github.com/kubewharf/kubeadmiral/actions/runs/6307418487/job/17124013179?pr=226

The error case is t.Run("ClusterEventHandlers should receive correct old and new clusters", func(t *testing.T).
I ran it locally multiple times and found no similar errors.

I feel that there is a small time difference between the function entering assertionCh and calling callback, which is captured by the test case. I think it would be better to put the callBackCount.Add(1) before the assertionCh operation.

@Poor12
Copy link
Collaborator Author

Poor12 commented Sep 26, 2023

/cc @limhawjia

@gary-lgy gary-lgy added the bug Something isn't working label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants