Update kind dependency to 0.8.4 #95
Conversation
ANeumann82
requested review from
gerred,
jbarrick-mesosphere,
kensipe and
zen-dog
as code owners
|
@kensipe mentioned some issues with |
|
No, they are not yet fixed, as far as I know. That's why I said I wouldn't want to merge this yet. If it turns you that it fixes the flakyness of our tests then we have to think about it... |
|
and what flakiness? I would expect flakiness to be a matter of test design.. not the kuttl itself... are you seeing something different? |
|
Yes, we can hold that. I've created this branch to build a local kuttl version that I currently use to test the C* kuttl tests. I will run repeated TC tests over the weekend to test if this would fix the issue. Wish it were the tests that were flaky, that would be easier to fix ;) We're running basically into this issue: This is mostly triggered because for the failure recovery we create a kind cluster with 4 nodes which increases the chance of this happening. |
|
So, as a quick update: All other flake causes are now fixed in the cassandra operator. There are still some flakes which come from this issue, but they are like 1 in 10 runs, so it's not too urgent to get this updated. Still - at some point I think we need to push to the new version |
|
@kensipe Any updates from your side? I'm not sure how we want to progress with this. I assume the issue you have with kind 0.8.1 is this one: kubernetes-sigs/kind#1558 Can you use the mentioned workaround? Getting this into kuttl is not the highest priority, but at some point we do need to upgrade, i guess - and the issue in the older kind versions are responsible for flakes in Cassandra. Not that often, but it is kind of annoying. |
There was a problem hiding this comment.
What is the purpose of the Ah, I see kudobuilder/kudo#1564 now.main branch?
| @@ -287,8 +288,11 @@ func TestRun(t *testing.T) { | |||
| }), | |||
| }, | |||
| }, func(t *testing.T, client client.Client) { | |||
| pod := testutils.NewPod("hello", testNamespace) | |||
| assert.Nil(t, client.Get(context.TODO(), types.NamespacedName{Namespace: testNamespace, Name: "hello"}, pod)) | |||
There was a problem hiding this comment.
How is this related to the bump?
There was a problem hiding this comment.
I'm not fully sure, but if it's not in there the test fails on Line 295 with "object was modified". So fetching it once before fixes that.
There was a problem hiding this comment.
The following fails
./hack/update_codegen.sh
Cloning code-generator from k8s.io/code-generator
Cloning into '/Users/kensipe/projects/go/src/github.com/kudobuilder/kuttl/hack/code-gen/v0.18.2'...
fatal: repository 'https://k8s.io/code-generator.git/' not found
which means that make generate fails
There was a problem hiding this comment.
code gen scripts were off for some reason :(
Aligned the versions with kudo project.
we should merge kudobuilder/kudo#1537 around the same time
Yeah, I looked into that as well. I think it got adjusted because we had a custom code-generator to include a bugfix that is now finally merged and released. Thanks for helping out with that. |
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Andreas Neumann <[email protected]>
Signed-off-by: Ken Sipe <[email protected]>
…ripts Signed-off-by: Ken Sipe <[email protected]>
Signed-off-by: Ken Sipe <[email protected]>
kensipe
changed the title
|
I looked into it: This PR needs to be merged and released before we can update and merge kudobuilder/kudo#1537 |
…l#95 Signed-off-by: Aleksey Dukhovniy <[email protected]>
Signed-off-by: Andreas Neumann [email protected]
What this PR does / why we need it:
We're currently investigating an issue in KUDO C* that may be related to kubernetes-sigs/kind#1288
It seems that KIND 0.8.1 fixes this issue.
Fixes #