You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(spawn): compare physical paths in treehouse wait loop for symlinked projects
Situation
Compliance: pass
Tests: green
Notes: compliance=pass tests=green
Triage
Summary: PR fix(spawn): compare physical paths in treehouse wait loop for symlinked projects firstmate#273 adds a new behavior-level regression test (tests/fm-spawn-symlink-wait.test.sh) for the treehouse wait loop's symlinked-project handling, syncs docs/CONTRIBUTING.md, and removes accidentally-committed local .omc/ state files (adding them to .gitignore), but its actual diff contains no change to bin/fm-spawn.sh.
Product implications: Worth a second look: the PR title/body claim to fix the wait loop by comparing physical paths in bin/fm-spawn.sh, but the diff never touches that file, and docs/herdr-backend.md (fix(spawn): compare physical paths in treehouse wait loop for symlinked projects firstmate#273's own diff context) shows the physical-path comparison was already fixed today under a separate backlog item 'fm-spawn-symlink-guard-s8' - the wait loop already uses PROJ_ABS_REAL. So this PR is really just an added regression test plus cleanup/doc-sync for an already-fixed bug, not the fix itself; the description overstates what the diff does, which the owner may want clarified before merging even though the actual changes are low-risk.
Recommended next step: look closer - confirm the code fix already landed via fm-spawn-symlink-guard-s8 and this PR is redundant test/doc/cleanup only, not a duplicate/conflicting fix
Recommended action
Merge - compliance and tests are green.
Your decision
Tick one box for a quick call, or reply with a slash-command (/merge, /close, /decline <reason>, /hold, /comment <text>, /request-changes <text>):
Merge it
Close / decline
Investigate - deep code-grounded review (leaves this card open)
Hold - I'll handle this manually
Only the repository owner can drive this decision - everyone else's edits and comments are ignored.
Decision needed - firstmate#273
PR review by wuyuwenj ·
merge-readySituation
passgreenTriage
Recommended action
Merge - compliance and tests are green.
Your decision
Tick one box for a quick call, or reply with a slash-command (
/merge,/close,/decline <reason>,/hold,/comment <text>,/request-changes <text>):Only the repository owner can drive this decision - everyone else's edits and comments are ignored.