Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge buildData with element creation and the available child rect calculation moved to element #122

Open
stockiNail opened this issue Sep 26, 2022 · 1 comment
Labels
breaking change A change which needs a major version because not compatible with previous versions
Milestone

Comments

@stockiNail
Copy link
Collaborator

From @kurkle #121 (comment)

buildData should be merged with element creation, and the available child rectangle calculation moved to element.

Something like

  • determine main rectangle
  • parse and create elements on this level
  • recurse

So actually quite much the same as the buildData, expect creating elements on the fly.

Use data option instead of tree one.

@stockiNail stockiNail added the breaking change A change which needs a major version because not compatible with previous versions label Sep 26, 2022
@stockiNail stockiNail added this to the 3.0.0 milestone Sep 26, 2022
@stockiNail
Copy link
Collaborator Author

Maybe the best solution is going to parse method of the controller, to split data and element creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A change which needs a major version because not compatible with previous versions
Projects
None yet
Development

No branches or pull requests

1 participant