Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

[Pairing Adapter] - Allow to specify OAuth Style #866

Closed
aszecowka opened this issue Feb 21, 2020 · 0 comments
Closed

[Pairing Adapter] - Allow to specify OAuth Style #866

aszecowka opened this issue Feb 21, 2020 · 0 comments
Assignees
Labels
area/management-plane Related to all activities around Management Plane kind/feature Categorizes issue or PR as related to a new feature.

Comments

@aszecowka
Copy link
Contributor

aszecowka commented Feb 21, 2020

In the current implementation, ClientID and ClientSecret are sent as a basic auth in the Authorization header.
Client ID and secret must be urlencoded in the authorization header, according to the RFC 6749 and our library is doing so: golang/oauth2@13449ad

Unfortunately, there are OAuth servers that do not decode those values (https://github.com/cloudfoundry/uaa), and as a result, we will get 401 Unauthorized Response: golang/oauth2#320.

As a workaround, client_id and client_secret can be sent in the body, and then this problem does not occur.

cc := clientcredentials.Config {	
		AuthStyle: oauth2.AuthStyleInParams,
}

Possible solution: Make auth style configurable in the Pairing Adapter via environment variable.

@aszecowka aszecowka added kind/feature Categorizes issue or PR as related to a new feature. area/management-plane Related to all activities around Management Plane labels Feb 21, 2020
@aszecowka aszecowka added this to the Sprint_X-Team_20 milestone Feb 21, 2020
@aszecowka aszecowka self-assigned this Feb 21, 2020
@PK85 PK85 closed this as completed Mar 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/management-plane Related to all activities around Management Plane kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants