Made changes for vue3sfcloader compatibility k-toolbar #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@viniarck I accidentally enabled a vue3 formatter in my VSCode plugins, should I disable it? |
|
I noticed now while making the pull request, but I don't know if I should keep the formatted code. |
HeriLFIU
changed the title
@HeriLFIU, I missed the other prior notification. Although the intention is great. I'd recommend avoid reformatting the code in this PR. In the future we can officialize a formatter and stick to it, but other than that for now it can create too much extra diffs, although not too difficult to follow but yes, it's more things to review and check for, so let's minimize that too for now, OK? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #539
Closes #520
Summary
These changes are made to that mef_eline k-toolbar can be loaded in by the vue3-sfc-loader.
The try and catch block would not function within the html it needed to be within its own method.
There were also some undefined variables.
Mef_eline also had an issue with its form tags, since they were incorrectly placed. They were placed inside of a k-accordion-item while still spanning multiple other outside elements. Because of this I placed it inside the single k-accordion-item.
Local Tests
End-to-End Tests