Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid sending a request if the switch just reconnected #31

Open
viniarck opened this issue Dec 17, 2021 · 0 comments
Open

Avoid sending a request if the switch just reconnected #31

viniarck opened this issue Dec 17, 2021 · 0 comments

Comments

@viniarck
Copy link
Member

Quoting @italovalcy to capture this requirement on this comment:

@viniarck another enhancement opportunity is: we should only request a flow_mod add when it is a new switch (or it was previously disabled before). The reason basically related to the fact the flow_manager should take care of reinstalling the flows once the switch reconnects. Currently, once a switch reconnects a new kytos/topology.switch.enabled event is generated (https://github.com/kytos-ng/topology/blob/master/main.py#L517-L530) and LLDP flows are requested again (even though they probably exists at the switch, if the switch only reconnected).
For the kytos/topology.switch.disabled event (the else branch of the conditional above), then it makes sense to remove the flows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant