Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make consistent GenericType initialization #24

Open
ajoaoff opened this issue Jun 7, 2021 · 0 comments
Open

make consistent GenericType initialization #24

ajoaoff opened this issue Jun 7, 2021 · 0 comments

Comments

@ajoaoff
Copy link

ajoaoff commented Jun 7, 2021

Original issue opened by @erickvermot at kytos#426.

GenericType accepts a value named argument in its initialization that defaults to None. I propose we keep the GenericType derivatives consistent, naming their initialization argument value and letting them accept None.

BinaryData case is treated in: kytos#420

and Pad is treated as a special case.

The proposed modifications were introduced in kytos#392 , and is now isolated in another branch (kytos/python-openflow@master...erickvermot:generictype_init_value_pr) since kytos#392 was rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant