feat(BA-760): Add scaling_group_name column to resource preset table #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2 tasks
fregataa
changed the title
fregataa
changed the title
fregataa
changed the title
fregataa
force-pushed
the
topic/02-16-feat_add_resource_group_id_column_to_resource_preset_table
branch
from
0553600 to
7523ea2
Compare
Comment on lines
+280
to
+284
| resource_preset_rows = relationship( | ||
| "ResourcePresetRow", | ||
| back_populates="scaling_group_row", | ||
| primaryjoin="ScalingGroupRow.name == foreign(ResourcePresetRow.scaling_group_name)", | ||
| ) |
There was a problem hiding this comment.
I'm not sure if you need to join based on the name, as it's not an ID value that needs to be joined.
There was a problem hiding this comment.
Sadly, scaling_groups table does not have id column and name column is a primary key of it
fregataa
force-pushed
the
topic/02-16-feat_add_resource_group_id_column_to_resource_preset_table
branch
from
7523ea2 to
30a689e
Compare
Co-authored-by: octodog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3716 (BA-760)
Checklist: (if applicable)