Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(BA-778): Modularize common if conditions #3706

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

ci(BA-778): Modularize common if conditions #3706

wants to merge 7 commits into from

Conversation

Yaminyam
Copy link
Member

@Yaminyam Yaminyam commented Feb 14, 2025 •
edited
Loading

resolves #3730 (BA-778)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@github-actions github-actions bot added the size:M 30~100 LoC label Feb 14, 2025
@Yaminyam Yaminyam changed the title ci: Modularize common if conditions ci(BA-778): Modularize common if conditions Feb 17, 2025
@Yaminyam Yaminyam marked this pull request as ready for review February 17, 2025 08:35
@Copilot Copilot bot review requested due to automatic review settings February 17, 2025 08:35
Copilot
Copilot AI reviewed Feb 17, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
@Yaminyam Yaminyam added the skip:ci Make the action workflow to skip running lint, check, and test (use with caution!) label Feb 20, 2025
@Yaminyam Yaminyam added the skip:changelog Make the action workflow to skip towncrier check label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@HyeockJinKim HyeockJinKim Awaiting requested review from HyeockJinKim

Assignees

@Yaminyam Yaminyam

Labels
size:M 30~100 LoC skip:changelog Make the action workflow to skip towncrier check skip:ci Make the action workflow to skip running lint, check, and test (use with caution!)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modularizes the job execution conditions of github actions
1 participant
@Yaminyam