Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BA-813): Update halfstack volume mappings for Grafana dashboards #3778

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rapsealk
Copy link
Member

@rapsealk rapsealk commented Feb 20, 2025

Follow-up of #3651 and resolves #3777 (BA-813)

This pull request fixes the target mount path for grafana service.

Before After
스크린샷 2025-02-20 오후 4 06 45 스크린샷 2025-02-20 오후 4 07 12

This pull request includes changes to the docker-compose.halfstack-2409.yml file to update the volume mappings for Grafana dashboards and provisioning directories.

Volume mapping updates:

Checklist: (if applicable)

  • Mention to the original issue

@rapsealk rapsealk added the type:bug Reports about that are not working label Feb 20, 2025
@rapsealk rapsealk self-assigned this Feb 20, 2025
@github-actions github-actions bot added the size:XS ~10 LoC label Feb 20, 2025
@rapsealk rapsealk added the skip:changelog Make the action workflow to skip towncrier check label Feb 20, 2025
@rapsealk rapsealk marked this pull request as draft February 20, 2025 10:16
@rapsealk
Copy link
Member Author

The main issue is that the ./scripts/install-dev.sh script fails to copy ./configs/grafana/dashboards/dashboard.json to ./grafana-dashboards/dashboard.json if an outdated ./grafana-dashboards directory with ./grafana-dashboards/dashboards/dashboard.json file already exists. To resolve the 'Dashboard not found' error, the correct solution is to ensure that the ./grafana-dashboards/dashboard.json file is copied properly.

@github-actions github-actions bot added size:S 10~30 LoC comp:installer Related to Installer and removed size:XS ~10 LoC labels Feb 20, 2025
@github-actions github-actions bot added size:XS ~10 LoC and removed size:S 10~30 LoC labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:installer Related to Installer size:XS ~10 LoC skip:changelog Make the action workflow to skip towncrier check type:bug Reports about that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grafana dashboard not found
2 participants