Refactor rotation handling and placement logic

Simplified and streamlined rotation management by consolidating `onUpdate` and `onReceive` callbacks. Improved code readability and consistency in `BuildTask` and `BreakBlock` tasks by refining placement and rotation operations. Removed unused comments and ensured proper alignment with updated rotation conventions.

Author: Avanatiker

common/src/main/kotlin/com/lambda/interaction/RotationManager.kt

@@ -56,7 +56,7 @@ object RotationManager : Loadable {
         priority: Int = 0,
         alwaysListen: Boolean = false,
         onUpdate: SafeContext.(lastContext: RotationContext?) -> RotationContext?,
-        onReceive: SafeContext.() -> Unit = {}
+        onReceive: SafeContext.(context: RotationContext) -> Unit = {}
     ) {
         var lastCtx: RotationContext? = null
 
@@ -71,8 +71,8 @@ object RotationManager : Loadable {
         }
 
         listen<RotationEvent.Post> { event ->
-            if (event.context == lastCtx && event.context.isValid) {
-                onReceive()
+            if (event.context == lastCtx) {
+                onReceive(event.context)
             }
         }
     }
@@ -123,20 +123,19 @@ object RotationManager : Loadable {
         currentRotation = currentContext?.let { context ->
             val rotationTo = if (keepTicks >= 0) context.rotation else player.rotation
 
-            rotationTo
-//            var speedMultiplier = (context.config as? RotationSettings)?.speedMultiplier ?: 1.0
-//            if (keepTicks < 0) speedMultiplier = 1.0
-//
-//            val turnSpeed = context.config.turnSpeed * speedMultiplier
-//
-//            currentRotation
-//                .slerp(rotationTo, turnSpeed)
-//                .fixSensitivity(prevRotation)
-//                .apply {
-//                    if (context.config.rotationMode != RotationMode.LOCK) return@apply
-//                    player.yaw = this.yawF
-//                    player.pitch = this.pitchF
-//                }
+            var speedMultiplier = (context.config as? RotationSettings)?.speedMultiplier ?: 1.0
+            if (keepTicks < 0) speedMultiplier = 1.0
+
+            val turnSpeed = context.config.turnSpeed * speedMultiplier
+
+            currentRotation
+                .slerp(rotationTo, turnSpeed)
+                .fixSensitivity(prevRotation)
+                .apply {
+                    if (context.config.rotationMode != RotationMode.LOCK) return@apply
+                    player.yaw = this.yawF
+                    player.pitch = this.pitchF
+                }
         } ?: player.rotation
     }
 

common/src/main/kotlin/com/lambda/task/tasks/BreakBlock.kt

@@ -25,6 +25,7 @@ import com.lambda.event.events.RotationEvent
 import com.lambda.event.events.TickEvent
 import com.lambda.event.events.WorldEvent
 import com.lambda.event.listener.SafeListener.Companion.listen
+import com.lambda.interaction.RotationManager.requestRotation
 import com.lambda.interaction.construction.context.BreakContext
 import com.lambda.interaction.visibilty.VisibilityChecker.lookAtBlock
 import com.lambda.module.modules.client.TaskFlowModule
@@ -71,6 +72,7 @@ class BreakBlock @Ta5kBuilder constructor(
             success(null)
             return
         }
+
         beginState = blockState
 
         if (!rotate || ctx.instantBreak) {
@@ -79,18 +81,17 @@ class BreakBlock @Ta5kBuilder constructor(
     }
 
     init {
-        listen<RotationEvent.Update> { event ->
-            if (state != State.BREAKING) return@listen
-            if (!rotate || ctx.instantBreak) return@listen
-            event.context = lookAtBlock(blockPos, rotation, interact, sides)
-        }
-
-        listen<RotationEvent.Post> {
-            if (state != State.BREAKING) return@listen
-            if (!rotate || ctx.instantBreak) return@listen
-
-            isValid = it.context.isValid
-        }
+        requestRotation(
+            onUpdate = {
+                if (state != State.BREAKING) return@requestRotation null
+                if (!rotate || ctx.instantBreak) return@requestRotation null
+
+                lookAtBlock(blockPos, rotation, interact, sides)
+            },
+            onReceive = { context ->
+                isValid = context.isValid
+            }
+        )
 
         listen<TickEvent.Pre> {
             drop?.let { itemDrop ->

common/src/main/kotlin/com/lambda/task/tasks/BuildTask.kt

@@ -81,11 +81,11 @@ class BuildTask @Ta5kBuilder constructor(
                 timeout
             }
 
-            currentPlacement?.let {
-                if (currentPlacement?.rotation?.isValid != true) return@listen
+            currentPlacement?.let { context ->
+                if (!context.rotation.isValid) return@listen
                 if (inScope++ < 1) return@listen // ToDo: Should not be needed but timings are wrong
-                it.place(interact.swingHand)
-                pendingPlacements.add(it)
+                context.place(interact.swingHand)
+                pendingPlacements.add(context)
                 currentPlacement = null
                 inScope = 0
             }