Fix vector substraction

Author: Avanatiker

common/src/main/kotlin/com/lambda/gui/api/component/core/DockingRect.kt

@@ -57,12 +57,15 @@ abstract class DockingRect {
     var screenSize: Vec2d = Vec2d.ZERO
 
     var position: Vec2d
-        get() = relativeToAbs(relativePos).coerceIn(0.0, screenSize.x - size.x, 0.0, screenSize.y - size.y)
+        get() = relativeToAbs(relativePos)
+            .coerceIn(0.0, screenSize.x - size.x, 0.0, screenSize.y - size.y)
         set(value) {
-            relativePos = absToRelative(value.roundToStep(ClickGui.dockingGridSize)); if (autoDocking) autoDocking()
+            relativePos = absToRelative(value.roundToStep(ClickGui.dockingGridSize))
+            if (autoDocking) autoDocking()
         }
 
-    private val dockingOffset get() = (screenSize - size) * Vec2d(dockingH.multiplier, dockingV.multiplier)
+    private val dockingOffset get() =
+        (screenSize - size) * Vec2d(dockingH.multiplier, dockingV.multiplier)
 
     private fun relativeToAbs(posIn: Vec2d) = posIn + dockingOffset
     private fun absToRelative(posIn: Vec2d) = posIn - dockingOffset

common/src/main/kotlin/com/lambda/util/math/MathUtils.kt

@@ -54,7 +54,7 @@ object MathUtils {
         BigDecimal(this).setScale(places, RoundingMode.HALF_EVEN).toDouble()
 
     private val Double.decimals: Int
-        get() = BigDecimal(this).scale()
+        get() = BigDecimal.valueOf(this).scale()
 
     fun <T : Number> T.typeConvert(valueIn: Double): T {
         @Suppress("UNCHECKED_CAST")
@@ -69,8 +69,7 @@ object MathUtils {
         } as T
     }
 
-    // TODO: wtf is this? is this just a coerce ?
-    fun Vec2d.roundToStep(step: Double): Vec2d =
+    fun Vec2d.roundToStep(step: Double) =
         Vec2d(x.roundToStep(step), y.roundToStep(step))
 
     fun random(v1: Double, v2: Double): Double {

common/src/main/kotlin/com/lambda/util/math/Vec2d.kt

@@ -23,15 +23,15 @@ data class Vec2d(val x: Double, val y: Double) {
     constructor(x: Float, y: Float) : this(x.toDouble(), y.toDouble())
     constructor(x: Int, y: Int) : this(x.toDouble(), y.toDouble())
 
-    operator fun unaryMinus(): Vec2d = Vec2d(-x, -y)
+    operator fun unaryMinus() = Vec2d(-x, -y)
 
     fun plus(x: Double, y: Double) = Vec2d(this.x + x, this.y + y)
     infix operator fun plus(other: Vec2d) = plus(other.x, other.y)
     infix operator fun plus(other: Double) = plus(other, other)
     infix operator fun plus(other: Float): Vec2d = plus(other.toDouble(), other.toDouble())
     infix operator fun plus(other: Int): Vec2d = plus(other.toDouble(), other.toDouble())
 
-    fun minus(x: Double, y: Double)= Vec2d(this.x + x, this.y + y)
+    fun minus(x: Double, y: Double) = Vec2d(this.x - x, this.y - y)
     infix operator fun minus(other: Vec2d): Vec2d = minus(other.x, other.y)
     infix operator fun minus(other: Double): Vec2d = minus(other, other)
     infix operator fun minus(other: Float): Vec2d = minus(other.toDouble(), other.toDouble())
@@ -49,7 +49,7 @@ data class Vec2d(val x: Double, val y: Double) {
     infix operator fun div(other: Float): Vec2d = div(other.toDouble(), other.toDouble())
     infix operator fun div(other: Int): Vec2d = div(other.toDouble(), other.toDouble())
 
-    fun roundToInt(): Vec2d = Vec2d(this.x.roundToInt(), this.y.roundToInt())
+    fun roundToInt() = Vec2d(x.roundToInt(), y.roundToInt())
 
     companion object {
         val ZERO = Vec2d(0.0, 0.0)