Improvement: Separate core from the rest of the setting to allow mutability (172)

Author: beanbag44

src/main/java/com/lambda/mixin/CrashReportMixin.java

@@ -18,7 +18,7 @@
 package com.lambda.mixin;
 
 import com.lambda.Lambda;
-import com.lambda.config.AbstractSetting;
+import com.lambda.config.Setting;
 import com.lambda.module.Module;
 import com.lambda.module.ModuleRegistry;
 import com.lambda.util.DynamicExceptionKt;
@@ -67,7 +67,7 @@ String injectString(ReportType type, List<String> extraInfo, Operation<String> o
 
                         module.getSettings()
                                 .stream()
-                                .filter(AbstractSetting::isModified)
+                                .filter(Setting::isModified)
                                 .forEach(setting -> list.add(String.format("\t\t%s -> %s", setting.getName(), setting.getValue())));
                     });
         }

src/main/kotlin/com/lambda/command/commands/ConfigCommand.kt

@@ -76,13 +76,13 @@ object ConfigCommand : LambdaCommand(
                     executeWithResult {
                         val confName = config().value()
                         val settingName = setting().value()
-                        val conf = Configuration.configurableByCommandName(confName) ?: run {
+                        val configurable = Configuration.configurableByCommandName(confName) ?: run {
                             return@executeWithResult failure("$confName is not a valid configurable.")
                         }
-                        val set = Configuration.settingByCommandName(conf, settingName) ?: run {
+                        val setting = Configuration.settingByCommandName(configurable, settingName) ?: run {
                             return@executeWithResult failure("$settingName is not a valid setting for $confName.")
                         }
-                        set.reset()
+                        setting.reset()
                         return@executeWithResult success()
                     }
                 }

src/main/kotlin/com/lambda/config/AbstractSetting.kt

@@ -59,8 +59,6 @@ open class AutomationConfig(
     override val hotbarConfig = HotbarSettings(this, Group.Hotbar)
     override val eatConfig = EatSettings(this, Group.Eat)
 
-    val hiddenSettings = mutableSetOf<AbstractSetting<*>>()
-
     companion object {
 		context(module: Module)
         fun MutableAutomationConfig.setDefaultAutomationConfig(